<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 5/2/22 1:53 PM, Manish Mehra via c-ares wrote:<br>
<blockquote type="cite"
cite="mid:CANHToyexCk9soxQCs=j+HqFe5aZt=Fpe-RXH5fmkUUsX+0qusA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>c-ares provides application to configure resolvconf path.
However, no support exists for configurable “hosts” file for
file_lookup function. <br>
</div>
<div><br>
</div>
<div>Please find attached diff which adds support for
ARES_OPT_HOSTS_FILE which can be set with ares_init_options
function.<br>
</div>
<div><br>
</div>
<div>--</div>
<div>Thanks,</div>
<div>Manish</div>
<div><br>
</div>
<div>P.S: Could not create a private branch for pull request. Is
there any policy in place to allow creation of private<br>
</div>
<div><br>
</div>
<div><span style="font-family:monospace"># git push origin
hosts_path_opt<br>
ERROR: Permission to c-ares/c-ares.git denied to mmehra.<br>
fatal: Could not read from remote repository.<br>
<br>
Please make sure you have the correct access rights<br>
and the repository exists.</span></div>
</div>
<br>
</blockquote>
<br>
The patch looks good at first glance, don't see why this wouldn't be
accepted.<br>
<br>
Regarding the issue creating a PR, I'd have to see more commands for
how you forked the repository, then set the remote and origin to say
where something might have messed up. <br>
<br>
If possible it would be great if you can try again
(<a class="moz-txt-link-freetext" href="https://docs.github.com/en/get-started/quickstart/fork-a-repo">https://docs.github.com/en/get-started/quickstart/fork-a-repo</a>) and
create a PR (once you commit to your fork, the github UI provides an
easy interface to create a PR, usually prompts you at the top when
you view your fork. A PR will then go through the c-ares auto-build
program to ensure all tests pass on all platforms. It makes it
easier to accept the patch.<br>
<br>
<br>
Thanks!<br>
-Brad<br>
</body>
</html>