libssh2 1.11.0 - sshd tests

[Paul Howarth]

Hi,

On Fri, 2 Jun 2023 13:55:22 -0400
Nicolas Mora via libssh2-devel <libssh2-devel at lists.haxx.se> wrote:
> I'm preparing the package libssh2 1.11.0 for Debian, but I have 
> questions concerning the sshd tests.
> 
> If I enable the sshd tests in the package builder for debian
> unstable, the sshd tests fail, although if I run the tests locally on
> my Debian stable, the sshd tests pass. It seems the sshd server isn't
> executed as it should be:
> 
> FAIL: test_sshd
> ===============
> 
> Fingerprint: 12 FD AD 1E 3B 31 B1 0B AB B0 0F 2A 8D 1B 9A 62 C3 26 BD
> 2F Authentication methods: publickey,password,keyboard-interactive
> Authentication by public key failed!
> all done
> libssh2_userauth_publickey_fromfile_ex failed (-18):
> Username/PublicKey combination invalid
> # sshd executable: '/usr/sbin/sshd' (OpenSSH_9.2, OpenSSL 3.0.9 30
> May 2023) # ssh executable: '/usr/bin/ssh' (OpenSSH_9.2p1 Debian-2,
> OpenSSL 3.0.9 30 May 2023)
> # waiting for sshd...
> # waiting for sshd...
> # waiting for sshd...
> # waiting for sshd...
> # waiting for sshd...
> # waiting for sshd...
> # waiting for sshd...
> # waiting for sshd...
> 1..2
> not ok 1 - sshd-test_ssh2
> FAIL: test_sshd.test 1 - sshd-test_ssh2
> not ok 2 - sshd-test_auth_pubkey_ok_ed25519
> FAIL: test_sshd.test 2 - sshd-test_auth_pubkey_ok_ed25519
> 
> Is there anything I could try to make the sshd tests work?

It might be that the builder's directory permissions are a little too
relaxed for sshd's liking. In Fedora I made this change to solve a
similar-looking issue:

--- tests/test_sshd.test
+++ tests/test_sshd.test
@@ -71,6 +71,7 @@ chmod go-rwx \
 # shellcheck disable=SC2086
 "${SSHD}" \
   -f "${SSHD_FIXTURE_CONFIG:-${d}/openssh_server/sshd_config}" \
+  -o 'StrictModes no' \
   -o 'Port 4711' \
   -h "${d}/openssh_server/ssh_host_rsa_key" \
   -h "${d}/openssh_server/ssh_host_ecdsa_key" \

Regards, Paul.