LIBSSH2_HOSTKEY_METHOD's hash_len

Peter Stuge peter at stuge.se
Fri Mar 31 04:30:23 CEST 2023


Patrick Monnerat via libssh2-devel wrote:
> I noticed two things about field hash_len of structure 
> _LIBSSH2_HOSTKEY_METHOD:
> 
> 1) It seems unused in the current code base,

That seems right.


> 2) If its goal is to describe the signing/verification algorithm, it is 
> wrongly set to MD5 in hostkey.c for hostkey_method_ssh_rsa, 
> hostkey_method_ssh_rsa_cert and hostkey_method_ssh_dss.

Also seems right.

ssh_rsa and ssh_dss should be SHA1, what about ssh-rsa-cert-v01?


> But please, don't remove it yet:

Let's just correct them. :)


//Peter


More information about the libssh2-devel mailing list